Adding Metdata on Player (Initial Draft) (TV)#2461
Adding Metdata on Player (Initial Draft) (TV)#2461phisher98 wants to merge 12 commits intorecloudstream:masterfrom
Conversation
fire-light42
left a comment
There was a problem hiding this comment.
Nice pull request. A more detailed review will be done after testing.
app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/player/GeneratorPlayer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/player/GeneratorPlayer.kt
Outdated
Show resolved
Hide resolved
fire-light42
left a comment
There was a problem hiding this comment.
The new UI looks really good, however I found a major UX bug. The problem is that the postDelayed never get cancelled, so pausing-unpausing repeatedly for 8 seconds will cause it to invoke the lambda several times even if you try to navigate.
Moreover, I also want to ask if it intentional to show the "Scrim" even when you navigate the UI, as you can pull up the UI by pressing Up on the dpad while paused.
app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt
Show resolved
Hide resolved
fire-light42
left a comment
There was a problem hiding this comment.
The code looks good, will do some further testing later.
|
@fire-light42 Any more changes needed ? |
There was a problem hiding this comment.
Looks good and works well but the metadataScrim should fade in and out as opposed to instantly appearing and disappearing.
If possible, see if you can make a more distinct visual difference between the synopsis and the meta row. If they are different it will be easier to distinguish where the synopsis starts at a glance. Notice how we display the synopsis in other places to make reading easier.
The yellow star indicating the ratings looks a bit out of place with the white font. You might not need to change this if you visually redesign the meta row.
Fade in 8 sec after paused